fix: schema validation in APIML components #4438
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
github-project-automation
bot
moved this to New
in API Mediation Layer Backlog Management
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
pablocarle
reviewed
Jan 7, 2026
discovery-package/src/main/resources/schemas/discovery-config.json
Outdated
Show resolved
Hide resolved
caching-service-package/src/main/resources/schemas/caching-service-config.json
Show resolved
Hide resolved
caching-service-package/src/main/resources/schemas/caching-service-config.json
Outdated
Show resolved
Hide resolved
caching-service-package/src/main/resources/schemas/caching-service-config.json
Outdated
Show resolved
Hide resolved
api-catalog-package/src/main/resources/schemas/api-catalog-config.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
EvaJavornicka
moved this from New
to In Progress
in API Mediation Layer Backlog Management
Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
|
pablocarle
reviewed
Jan 23, 2026
| }, | ||
| "sslDebug": { | ||
| "type": "string", | ||
| "description": "Configure attributes fro SSL config, see java property javax.net.debug." |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Configure attributes fro SSL config, see java property javax.net.debug." | |
| "description": "Configure attributes for SSL config, see java property javax.net.debug." |
| }, | ||
| "sslDebug": { | ||
| "type": "string", | ||
| "description": "Configure attributes fro SSL config, see java property javax.net.debug." |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Configure attributes fro SSL config, see java property javax.net.debug." | |
| "description": "Configure attributes for SSL config, see java property javax.net.debug." |
Comment on lines
+558
to
+563
| "description": "How many connections should exist for single route?", | ||
| "default": 100 | ||
| }, | ||
| "maxTotalConnections": { | ||
| "type": "integer", | ||
| "description": "How many connections should exist in total?", |
Contributor
There was a problem hiding this comment.
are these descriptions (in general) shown in logs or other places? Should they go with review from doc squad? Wondering about the description with question marks
| "properties": { | ||
| "port": { | ||
| "$ref": "#/$defs/port", | ||
| "default": 7553 |
Contributor
There was a problem hiding this comment.
Suggested change
| "default": 7553 | |
| "default": 7554 |
| "properties": { | ||
| "port": { | ||
| "$ref": "#/$defs/port", | ||
| "default": 7552 |
Contributor
There was a problem hiding this comment.
Suggested change
| "default": 7552 | |
| "default": 7553 |
| "properties": { | ||
| "enabled": { | ||
| "type": "boolean", | ||
| "description": "To enable SSL/tls layer.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "To enable SSL/tls layer.", | |
| "description": "To enable SSL/TLS layer.", |
Comment on lines
+189
to
+193
| "internal": { | ||
| "type": "object", | ||
| "description": "Single-service specific configuration", | ||
| "properties": { | ||
| "discovery": { |
Contributor
There was a problem hiding this comment.
I think the property is named internal-discovery, though for now we pick it from the discovery component setting in first order
| "description": "To enable accepting client certificate from request header. It is used in domain APIML to accept forwarded client certificate by the caller.", | ||
| "default": false | ||
| }, | ||
| "certificatesUrl": { |
Contributor
There was a problem hiding this comment.
I think one of these two is deprecated, I'm inclined to think it's the one in singular
Comment on lines
+505
to
+509
| "provider": { | ||
| "type": "string", | ||
| "description": "Method of communication used by the SAF IDT provider implementation. REST is used if no value is provided.", | ||
| "enum": ["rest"], | ||
| "default": "rest" |
Contributor
There was a problem hiding this comment.
I think this one should allow for custom values (thinking about extensions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is fixes the schema validation in APIML components. See, the linked issue.
Linked to #3142
Type of change
Checklist:
For more details about how should the code look like read the Contributing guideline